Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging Dev into main to include latest commits about work items #32151, #32068, #31953 #118

Merged
merged 106 commits into from
Feb 12, 2024
Merged

Merging Dev into main to include latest commits about work items #32151, #32068, #31953 #118

merged 106 commits into from
Feb 12, 2024

Conversation

Brunoga-MS
Copy link
Contributor

@Brunoga-MS Brunoga-MS commented Feb 8, 2024 •
edited by arjenhuitema
Loading

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Remove unnecessary concat string instructions as per work item #31953
  2. Fix the PIP VIP alert existence condition to only check for standard sku as per work item #32151
  3. Add a new Storage Account Delete Alert as per workitem #32068
  4. Changed deployment documentation to use common parts (see the parameter configuration file which contain the text in common among PowerShell, AzureCLI, GitHub and Azure Pipelines deployment docs.
  5. Added a name to deployments so the parent AMBA deployments can be recognized by name.
  6. Added a script to remove AMBA deployments

Breaking Changes

  1. NONE

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Brunoga-MS
testing new approach
63200f9
@Brunoga-MS
Fixing template file
f327d06
@Brunoga-MS
Updating template file
293e842
@Brunoga-MS
fixing issue with parameters
05902f1
@Brunoga-MS
Merge branch 'Dev' of https://github.com/Brunoga-MS/azure-monitor-bas…
d50ff14 
…eline-alerts into Dev
@Brunoga-MS
Fixing parameter issue
425ed99
@Brunoga-MS
Fixing missing parameters
9b2b045
@Brunoga-MS
fixing unused params
3a90c39
@Brunoga-MS
fixing missing params
5b91a42
@Brunoga-MS
fixing names and params
968a9dd
@Brunoga-MS
Adding FunctionApp to the list of Action groups
b5e5633
@Brunoga-MS
Adding missing params in the policySetDefinition file
1d0f98b
@Brunoga-MS
Adding missing params
926eef5
@Brunoga-MS
Adding missing params
8ef641d
@Brunoga-MS
reducing notification parameters
8cffbeb
@Brunoga-MS
reducing parameters
7d6ac13
@Brunoga-MS
Adding one existence condition
a549957
@Brunoga-MS
updated existenceCondition for SH
3c33f51
@Brunoga-MS
fixing the hnadling of empty parameters for Actions
da66fe7
@Brunoga-MS
Adding notifications to ResourceHealth alert
821abd0
@Brunoga-MS
managing multiple actions with multiple entries in one AG
fdf69ab
@Brunoga-MS
managing multiple actions with multiple entries in one AG 2
1b35946
@Brunoga-MS
Adding notification assets
9d492eb
@Brunoga-MS
Fixing wrong assignment to Action Group and
3413c29
@Brunoga-MS
Removing custom parameter file not necessary for the official source …
58fa7d0 
…code
@Brunoga-MS
Adding subscription display name to the Alert Processing Rule
4051c6c
@Brunoga-MS
Fixing issues with:
8a44037 
- Logic App callback url
- Function App trigger url
@Brunoga-MS
Fixing issues for:
d8d54aa 
- LogicApp callbalck url
- Function App Trigger Url
on SH Action group
@Brunoga-MS
Updating policies.json file
b171496
@Brunoga-MS
Aligning template and parameter file
e379be8
Brunoga-MS and others added 13 commits January 19, 2024 14:56
@Brunoga-MS Brunoga-MS linked an issue Feb 12, 2024 that may be closed by this pull request
[Question/Feedback]: Action groups with other than email for distribution #51
Closed
1 task
arjenhuitema
arjenhuitema approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@arjenhuitema arjenhuitema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjenhuitema arjenhuitema merged commit be145bd into main Feb 12, 2024
2 of 4 checks passed
@arjenhuitema arjenhuitema deleted the Dev branch February 12, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjenhuitema arjenhuitema arjenhuitema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question/Feedback]: Action groups with other than email for distribution
2 participants
@Brunoga-MS @arjenhuitema